Issue 174046: Make gadgets.rpc resilient to double-inclusion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 174046: Make gadgets.rpc resilient to double-inclusion (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 9 months ago by johnfargo

Modified:
15 years, 9 months ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

This small patch makes it possible to doubly-include rpc.js in a given page, preventing problems from occurring when this occurs. This happens in various mixed-rendering cases, and the code to prevent it is fairly small, much more easily obviating the need for custom prevention code from having to be written.

Patch Set 1 #

Created: 15 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
features/src/main/javascript/features/rpc/fe.transport.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/rpc/ifpc.transport.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/rpc/nix.transport.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/rpc/rmr.transport.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/rpc/rpc.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/rpc/wpm.transport.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fargo

15 years, 9 months ago (2009-12-10 21:29:17 UTC) #3

Thanks Paul, committed.

On Thu, Dec 10, 2009 at 1:27 PM, <lindner@inuus.com> wrote:

> lgtm
>
>
> http://codereview.appspot.com/174046
>

Expand All Messages | Collapse All Messages