Issue 1739042: code review 1739042: exp/draw/x11: implement the mapping from keycodes to ke...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1739042: code review 1739042: exp/draw/x11: implement the mapping from keycodes to ke... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by nigeltao

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev, rog

Visibility:
Public.

Description

exp/draw/x11: implement the mapping from keycodes to keysyms.

Patch Set 2 : code review 1739042: exp/draw/x11: implement the mapping from keycodes to ke... #

Patch Set 3 : code review 1739042: exp/draw/x11: implement the mapping from keycodes to ke... #

Total comments: 2

Patch Set 4 : code review 1739042: exp/draw/x11: implement the mapping from keycodes to ke... #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -31 lines)			Patch
	M	src/pkg/exp/draw/x11/conn.go	View	1 2 3	5 chunks	+78 lines, -31 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc (cc: golang-dev@googlegroups.com, rog), I'd like you to review this change.

15 years, 1 month ago (2010-06-24 13:40:03 UTC) #1

nigeltao_gnome

On 24 June 2010 23:40, <nigeltao@golang.org> wrote: > Description: > exp/draw/x11: implement the mapping from ...

15 years, 1 month ago (2010-06-26 23:35:42 UTC) #2

rsc1

LGTM http://codereview.appspot.com/1739042/diff/6001/7001 File src/pkg/exp/draw/x11/conn.go (right): http://codereview.appspot.com/1739042/diff/6001/7001#newcode173 src/pkg/exp/draw/x11/conn.go:173: for i := 0; i < 256; i++ ...

15 years, 1 month ago (2010-06-28 21:06:36 UTC) #3

nigeltao

15 years, 1 month ago (2010-06-29 00:54:40 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b459ef9196f4 ***

exp/draw/x11: implement the mapping from keycodes to keysyms.

R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/1739042

Expand All Messages | Collapse All Messages