Issue 1733042: code review 1733042: make colons optional in text parser. (missed update in ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1733042: code review 1733042: make colons optional in text parser. (missed update in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by r

Modified:
15 years, 1 month ago

Reviewers:

CC:
dsymonds2, dsymonds

Visibility:
Public.

Description

make colons optional in text parser. (missed update in google-internal code) add test.

Patch Set 1 #

Patch Set 2 : code review 1733042: make colons optional in text parser. (missed update in ... #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
	M	proto/text_parser.go	View		1 chunk	+10 lines, -7 lines	0 comments	Download
	M	proto/text_parser_test.go	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

15 years, 1 month ago (2010-06-22 22:51:24 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=3cf1c4f2acec ***

make colons optional in text parser. (missed update in google-internal code)
add test.

R=dsymonds, dsymonds1
http://codereview.appspot.com/1733042

Expand All Messages | Collapse All Messages