Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1117)

Issue 1724041: 100+ warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by paPus
Modified:
13 years, 9 months ago
Reviewers:
carl.d.sorensen, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

My main concern was fixing the warnings (~150, mostly vsize vs. int), and getting to know the codebase a bit. It consists mainly of int casts, with a few return value and syntax changes, and unused variable name deletions. Nothing serious. Make check gave no warnings, but please check it also. I will post the second set of warning patches, once this was accepted (It's ready, I just don't want the patches to pile up)

Patch Set 1 #

Total comments: 1

Patch Set 2 : I've separated the warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -163 lines) Patch
M flower/cpu-timer.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M flower/file-cookie.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M flower/file-name.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M flower/getopt-long.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M flower/libc-extension.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M flower/polynomial.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M flower/rational.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M flower/std-string.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M flower/string-convert.cc View 1 7 chunks +16 lines, -19 lines 0 comments Download
M lily/auto-beam-engraver.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/axis-group-interface.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/beam.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M lily/beam-concave.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lily/beam-quanting.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/beaming-pattern.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lily/break-alignment-interface.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/break-substitution.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M lily/chord-tremolo-iterator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/cluster.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/constrained-breaking.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M lily/dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/duration.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/engraver-group.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/figured-bass-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/fingering-engraver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/font-metric.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/font-metric-scheme.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/font-select.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/general-scheme.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/global-context.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/grid-line-span-engraver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/grob-array-scheme.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/hara-kiri-group-spanner.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/horizontal-bracket-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/page-breaking.hh View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/include/page-turn-page-breaking.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/pointer-group-interface.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/source-file.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/stem.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/system.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/least-squares.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/lily-guile.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lily/lily-lexer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/lily-parser-scheme.cc View 1 chunk +3 lines, -1 line 0 comments Download
M lily/lookup.cc View 1 3 chunks +9 lines, -11 lines 0 comments Download
M lily/midi-chunk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/midi-item.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M lily/new-fingering-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/note-collision.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/note-head.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M lily/page-breaking.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M lily/pointer-group-interface.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/source-file.cc View 1 8 chunks +11 lines, -18 lines 0 comments Download
M lily/stem.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M lily/system.cc View 1 9 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 15
Carl
Wow -- what a lot of code janitoring! Thanks for the effort! I'm not the ...
13 years, 9 months ago (2010-06-16 21:25:31 UTC) #1
paPus
I would have split it into chunks, but my main concern was warnings, which was ...
13 years, 9 months ago (2010-06-16 21:49:33 UTC) #2
c_sorensen
On 6/16/10 3:49 PM, "papuska@gmail.com" <papuska@gmail.com> wrote: > Reviewers: carl.d.sorensen_gmail.com, > > Message: > I ...
13 years, 9 months ago (2010-06-17 00:51:08 UTC) #3
paPus
> I prefer to always use (type-name) expression because the same syntax applies to both ...
13 years, 9 months ago (2010-06-17 02:10:29 UTC) #4
c_sorensen
On 6/16/10 8:10 PM, "papuska@gmail.com" <papuska@gmail.com> wrote: >> I prefer to always use (type-name) expression ...
13 years, 9 months ago (2010-06-17 03:32:30 UTC) #5
hanwenn
* can you split this up by type of change? ie. one commit doing cosmetics ...
13 years, 9 months ago (2010-06-17 03:34:37 UTC) #6
hanwenn
On 2010/06/17 02:10:29, paPus wrote: > ps. why are many macros (MAKE_SCHEME_CALLBACK, ADD_INTERFACE etc) ended ...
13 years, 9 months ago (2010-06-17 03:39:12 UTC) #7
paPus
> * can you split this up by type of change? ie. one commit doing ...
13 years, 9 months ago (2010-06-17 10:56:05 UTC) #8
paPus
> I ask that you submit the changes in a separated way: it's easier to ...
13 years, 9 months ago (2010-06-17 14:56:32 UTC) #9
Graham Percival
On Thu, Jun 17, 2010 at 3:56 PM, <papuska@gmail.com> wrote: >> Did you run the ...
13 years, 9 months ago (2010-06-17 16:16:04 UTC) #10
paplorinc_yahoo.com
> > - I just did (make check?), it fails (I guess, I'm not sure ...
13 years, 9 months ago (2010-06-18 23:04:24 UTC) #11
c_sorensen
On 6/18/10 5:04 PM, "Pap Lôrinc" <paplorinc@yahoo.com> wrote: >>> - I just did (make check?), ...
13 years, 9 months ago (2010-06-19 00:03:01 UTC) #12
paplorinc_yahoo.com
> HTH - Thanks Carl, but I've applied the imagemagick patch, did a long clean ...
13 years, 9 months ago (2010-06-19 01:09:20 UTC) #13
Patrick McCarty
On Fri, Jun 18, 2010 at 6:09 PM, Pap Lôrinc <paplorinc@yahoo.com> wrote: >> HTH > ...
13 years, 9 months ago (2010-06-19 02:34:13 UTC) #14
paPus
13 years, 9 months ago (2010-06-19 21:06:21 UTC) #15
Thank you Patrick, I have reinstalled imagemagick also, and now it was finally
working.
  It took me some time to get familiar with vmware, Linux (again), Eclipse CDT,
GIT, Lily etc :).
Thanks for the patience :).

  I've separated the warnings patch
(http://codereview.appspot.com/1724041/show). Since it's my first patch here, I
would kindly ask, that someone checks the regressions again.
I hope it's OK now :), please tell me, if it ain't :).

Thanks,
  Lőrinc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b