Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3698)

Issue 1723043: Use hex checsum for hash key instead of raw

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by zhoresh
Modified:
14 years, 4 months ago
Reviewers:
johnfargo, Paul Lindner, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.

Description

To make it easy to debug and support, changing cache keys to use hex checksum instead of raw checksum

Patch Set 1 #

Messages

Total messages: 3
zhoresh
14 years, 4 months ago (2010-06-18 23:07:57 UTC) #1
Paul Lindner
Seems okay. I'd be happier if we had a better toHex() routine that used a ...
14 years, 4 months ago (2010-06-18 23:31:50 UTC) #2
zhoresh
14 years, 4 months ago (2010-06-18 23:40:28 UTC) #3
It all thanks to Eclipse for fixing spaces, overrides etc. :)
Committed, thanks for looking into improving the hex convert.

On Fri, Jun 18, 2010 at 4:31 PM, <lindner@inuus.com> wrote:

> Seems okay.  I'd be happier if we had a better toHex() routine that used
> a lookup table and a fixed char array rather than a stringbuilder..  If
> you commit this patch I'll fix the latter.
>
> lots of whitespace only changes..  thanks for adding @Override
>
>
> http://codereview.appspot.com/1723043/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b