Seems okay. I'd be happier if we had a better toHex() routine that used a ...
14 years, 4 months ago
(2010-06-18 23:31:50 UTC)
#2
Seems okay. I'd be happier if we had a better toHex() routine that used a
lookup table and a fixed char array rather than a stringbuilder.. If you commit
this patch I'll fix the latter.
lots of whitespace only changes.. thanks for adding @Override
It all thanks to Eclipse for fixing spaces, overrides etc. :) Committed, thanks for looking ...
14 years, 4 months ago
(2010-06-18 23:40:28 UTC)
#3
It all thanks to Eclipse for fixing spaces, overrides etc. :)
Committed, thanks for looking into improving the hex convert.
On Fri, Jun 18, 2010 at 4:31 PM, <lindner@inuus.com> wrote:
> Seems okay. I'd be happier if we had a better toHex() routine that used
> a lookup table and a fixed char array rather than a stringbuilder.. If
> you commit this patch I'll fix the latter.
>
> lots of whitespace only changes.. thanks for adding @Override
>
>
> http://codereview.appspot.com/1723043/show
>
Issue 1723043: Use hex checsum for hash key instead of raw
Created 14 years, 4 months ago by zhoresh
Modified 14 years, 4 months ago
Reviewers: dev-remailer_shindig.apache.org, johnfargo, Paul Lindner
Base URL: http://svn.apache.org/repos/asf/shindig/trunk
Comments: 0