code review 1722046: rpc: allow non-struct args and reply (they must still b...

rpc: allow non-struct args and reply (they must still be pointers)

[r, 2010-06-25 22:15:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[r, 2010-06-25 22:16:01]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-28 20:07:28]

LGTM

http://codereview.appspot.com/1722046/diff/7001/4
File src/pkg/rpc/server.go (left):

http://codereview.appspot.com/1722046/diff/7001/4#oldcode49
src/pkg/rpc/server.go:49: type Reply struct {
Keep type Reply; use in Divide.
Just so that there is still an example with a struct result.

[r, 2010-06-28 21:16:26]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-28 21:24:02]

http://codereview.appspot.com/1722046/diff/10001/11001
File src/pkg/rpc/server.go (right):

http://codereview.appspot.com/1722046/diff/10001/11001#newcode179
src/pkg/rpc/server.go:179: // Is this a publicly visible type?
Also used for field names; cannot change meaning here.
Otherwise will write to field named "bool" or crash calling
method named bool.

Instead, wherever isPublic is being called with a typ.Name(),
don't call it for typ.PkgPath() == "".

[r, 2010-06-28 21:41:10]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-28 22:54:41]

http://codereview.appspot.com/1722046/diff/16001/17001
File src/pkg/rpc/server.go (right):

http://codereview.appspot.com/1722046/diff/16001/17001#newcode179
src/pkg/rpc/server.go:179: // Is this a publicly visible type?
still need to replace this with original comment + code

[r, 2010-06-28 22:58:59]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-28 23:05:08]

LGTM

[r, 2010-06-28 23:05:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=17587f9bc72b ***

rpc: allow non-struct args and reply (they must still be pointers)

R=rsc
CC=golang-dev
http://codereview.appspot.com/1722046