code review 1718042: Effective Go: panic and recover

Effective Go: panic and recover

[r, 2010-06-18 00:24:52]

Hello rsc, iant (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-06-18 02:30:39]

I think it would help to have a paragraph at the end
of the recover section saying that while using panic
and recover to handle this kind of thing inside a library
is often useful, the convention is to avoid exposing
panics across package boundaries: Regexp.Parse still
returns an error; it doesn't push a panic onto the caller.

http://codereview.appspot.com/1718042/diff/1/2
File doc/effective_go.html (right):

http://codereview.appspot.com/1718042/diff/1/2#newcode2667
doc/effective_go.html:2667: go do(work)
s/go //

http://codereview.appspot.com/1718042/diff/1/2#newcode2702
doc/effective_go.html:2702: func Compile(str string) (regexp *Regexp, error
os.Error) {
s/error/err/

http://codereview.appspot.com/1718042/diff/1/2#newcode2711
doc/effective_go.html:2711: return regexp.doParse(str)
s/$/, nil/

[r, 2010-06-18 02:41:26]

Hello rsc, iant (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-18 04:04:15]

LGTM

[r, 2010-06-18 04:57:19]

notes to myself for when i'm back at work

http://codereview.appspot.com/1718042/diff/5001/6001
File doc/effective_go.html (right):

http://codereview.appspot.com/1718042/diff/5001/6001#newcode2664
doc/effective_go.html:2664: log.Stderr("work failed:", err)
note to self: s2/err/e/ or change the variable name

http://codereview.appspot.com/1718042/diff/5001/6001#newcode2680
doc/effective_go.html:2680: function can get out of any bad situation cleanly by
calling
s/function/& or anything it calls/

http://codereview.appspot.com/1718042/diff/5001/6001#newcode2702
doc/effective_go.html:2702: func Compile(str string) (regexp *Regexp, err
os.Error) {
put a comment on Compile

http://codereview.appspot.com/1718042/diff/5001/6001#newcode2722
doc/effective_go.html:2722: it.  This check means that if something unexpected
happens, such
"it" has no referent

[r, 2010-06-18 17:52:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=f86b3c22d7b0 ***

Effective Go: panic and recover

R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1718042