Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 1704046: code review 1704046: 6a: assemble CMPPD as 6l expects (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by rsc
Modified:
15 years ago
Reviewers:
ken3
CC:
ken2, Charlie Dorian, golang-dev
Visibility:
Public.

Description

6a: assemble CMPPD as 6l expects libmach: disassemble CMPPD as 6a expects

Patch Set 1 #

Patch Set 2 : code review 1704046: 6a: assemble CMPPD as 6l expects #

Patch Set 3 : code review 1704046: 6a: assemble CMPPD as 6l expects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/cmd/6a/a.y View 1 chunk +1 line, -1 line 0 comments Download
M src/libmach/8db.c View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: Charlie Dorian, golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-07-01 19:36:27 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=9b073a5cfed8 *** 6a: assemble CMPPD as 6l expects libmach: disassemble CMPPD as ...
15 years ago (2010-07-01 19:36:33 UTC) #2
ken3
15 years ago (2010-07-01 19:52:35 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b