Issue 1700048: code review 1700048: cgo: use slash-free relative paths for .so references

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1700048: code review 1700048: cgo: use slash-free relative paths for .so references (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 10 months ago

Reviewers:

CC:
iant, r, golang-dev

Visibility:
Public.

Description

cgo: use slash-free relative paths for .so references The Makefile and cgo now rewrite / to _ when creating the path. The .so for gosqlite.googlecode.com/hg/sqlite is named cgo_gosqlite.googlecode.com_hg_sqlite.so, and then 6l and 8l both include a default rpath of $GOROOT/pkg/$GOOS_$GOARCH. This should make it easier to move binaries from one system to another. Fixes issue 857.

Patch Set 1 #

Patch Set 2 : code review 1700048: cgo: use slash-free relative paths for .so references #

Patch Set 3 : code review 1700048: cgo: use slash-free relative paths for .so references #

Patch Set 4 : code review 1700048: cgo: use slash-free relative paths for .so references #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -10 lines)			Patch
M	src/Make.pkg	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/cmd/5l/obj.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/6l/obj.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/8l/obj.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1 2 3	5 chunks	+24 lines, -8 lines	0 comments	Download
M	src/cmd/ld/macho.c	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello iant, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-07-01 03:02:26 UTC) #1

rsc

added, thanks for the reminder. i didn't think 5l knew about dynamic libraries. On Wed, ...

14 years, 10 months ago (2010-07-01 06:29:24 UTC) #4

rsc

14 years, 10 months ago (2010-07-01 06:31:29 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=f04a16455355 ***

cgo: use slash-free relative paths for .so references

The Makefile and cgo now rewrite / to _ when creating the path.
The .so for gosqlite.googlecode.com/hg/sqlite is named
cgo_gosqlite.googlecode.com_hg_sqlite.so, and then 6l and 8l
both include a default rpath of $GOROOT/pkg/$GOOS_$GOARCH.
This should make it easier to move binaries from one system
to another.

Fixes issue 857.

R=iant, r
CC=golang-dev
http://codereview.appspot.com/1700048

Expand All Messages | Collapse All Messages