code review 1699050: Added Bazaar+Launchpad support in goinstall

Added Bazaar+Launchpad support in goinstall

With these changes, goinstall is now able to use branches
maintained with Bazaar located in Launchpad.

Project aliases such as /project and /project/series are
supported in addition to specific user or team branches
such as /~user/project/branch.  Temporary branches under
the +junk special project are also supported.

As a curious side effect, since Launchpad is able to import
code from other locations, they can be indirectly
accessible too if desired.

[niemeyer, 2010-06-26 17:29:53]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-06-28 21:17:44]

looks pretty good; thanks

http://codereview.appspot.com/1699050/diff/2001/3001
File src/cmd/goinstall/doc.go (right):

http://codereview.appspot.com/1699050/diff/2001/3001#newcode45
src/cmd/goinstall/doc.go:45: Launchpad
wrong indentation

http://codereview.appspot.com/1699050/diff/2001/3002
File src/cmd/goinstall/download.go (right):

http://codereview.appspot.com/1699050/diff/2001/3002#newcode37
src/cmd/goinstall/download.go:37: var launchpad =
regexp.MustCompile(`^(launchpad\.net/([a-z0-9A-Z_.\-]+(/[a-z0-9A-Z_.\-]+)?|~[a-z0-9A-Z_.\-]+/(\+junk|[a-z0-9A-Z_.\-]+)/[a-z0-9A-Z_.\-]+))(/[a-z0-9A-Z_.\-/]+)?$`)
Really?  +junk ?

http://codereview.appspot.com/1699050/diff/2001/3002#newcode187
src/cmd/goinstall/download.go:187: // XXX What is the expected behavior with svn
here?  This seems
// NOTE(n13m3y3r@gmail.com): What is the expected behavior with svn here?
// "svn log -l1 release" doesn't make sense in this context and will probably
fail.

[niemeyer, 2010-06-28 21:46:30]

Thanks for the review.  Changes addressed.

http://codereview.appspot.com/1699050/diff/2001/3001
File src/cmd/goinstall/doc.go (right):

http://codereview.appspot.com/1699050/diff/2001/3001#newcode45
src/cmd/goinstall/doc.go:45: Launchpad
On 2010/06/28 21:17:44, rsc1 wrote:
> wrong indentation
> 

Done.

http://codereview.appspot.com/1699050/diff/2001/3002
File src/cmd/goinstall/download.go (right):

http://codereview.appspot.com/1699050/diff/2001/3002#newcode37
src/cmd/goinstall/download.go:37: var launchpad =
regexp.MustCompile(`^(launchpad\.net/([a-z0-9A-Z_.\-]+(/[a-z0-9A-Z_.\-]+)?|~[a-z0-9A-Z_.\-]+/(\+junk|[a-z0-9A-Z_.\-]+)/[a-z0-9A-Z_.\-]+))(/[a-z0-9A-Z_.\-/]+)?$`)

> Really?  +junk ?

Yeah, I know it sounds weird.  The background of the naming is that this
discourages people from using this unless it's indeed something temporary. 
Users can push branches such as "~myself/project/branch-name" to any project,
without special authorization from the project itself, and this what's
encouraged as it enhances organization.

http://codereview.appspot.com/1699050/diff/2001/3002#newcode187
src/cmd/goinstall/download.go:187: // XXX What is the expected behavior with svn
here?  This seems
Done.  I've just used my actual email instead.

[niemeyer, 2010-06-28 21:48:20]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-30 21:51:27]

LGTM

Could you please complete the CLA as described at
http://golang.org/doc/contribute.html#copyright ?

Thanks.

[gustavo_niemeyer.net, 2010-06-30 22:24:15]

> Could you please complete the CLA as described at
> http://golang.org/doc/contribute.html#copyright ?

I've already done that before submitting the change last week. You
should have it as "gustavo@niemeyer.net", which is the email I
actually use personally.  I used it to login with hg too, but I guess
it has translated it to my Gmail account which is unfortunately a bit
cryptic.

-- 
Gustavo Niemeyer
http://niemeyer.net
http://niemeyer.net/blog
http://niemeyer.net/twitter

[rsc, 2010-07-01 00:19:01]

On Wed, Jun 30, 2010 at 15:23, Gustavo Niemeyer <gustavo@niemeyer.net> wrote:
>> Could you please complete the CLA as described at
>> http://golang.org/doc/contribute.html#copyright ?
>
> I've already done that before submitting the change last week. You
> should have it as "gustavo@niemeyer.net", which is the email I
> actually use personally.  I used it to login with hg too, but I guess
> it has translated it to my Gmail account which is unfortunately a bit
> cryptic.

Ah, I see it.  Sorry about that.

The Mercurial plugin requires that the email address
we get from code review (the gmail one) be listed
in the CONTRIBUTORS file, because there's an
automated check that any code added to the repository
is from someone who has been okayed as a contributor.

We've had a few people in this situation before.
There are three things we could do.

2. Add you to the file with both addresses, so that
the check will find the gmail address, but with the
non-gmail address marked as the preferred one
for use in the check-in logs.

1. Cut the association between your gmail and
your non-gmail address.  You'd then have to create
a separate account+password for the non-gmail
address, and use that to log in to code review.

2. Add you to the CONTRIBUTORS file using your
gmail address.  Checkins will use the gmail address too.
The non-gmail address would go unused.

3. Add you to the CONTRIBUTORS file with both addresses.
The Mercurial plugin would find you via the gmail address
but there would be a notation on the line to say that checkins
should use the non-gmail address.

It really boils down to which address you want in the
Mercurial logs and how much you care about not
exposing the gmail address.

Let me know which you'd prefer.

Thanks, and sorry for the trouble.
Russ

[gustavo_niemeyer.net, 2010-07-01 01:40:48]

> 3. Add you to the CONTRIBUTORS file with both addresses.
> The Mercurial plugin would find you via the gmail address
> but there would be a notation on the line to say that checkins
> should use the non-gmail address.

This sounds like the best option.  I can't cut the association with
the Gmail account because I actually use my personal email to receive
and deliver from there, so this would be the only other choice which
would keep the real email around.  If that works, it certainly looks
good for me.

> It really boils down to which address you want in the
> Mercurial logs and how much you care about not
> exposing the gmail address.
>
> Let me know which you'd prefer.
>
> Thanks, and sorry for the trouble.

No problem, and thanks for your help with the check in

-- 
Gustavo Niemeyer
http://niemeyer.net
http://niemeyer.net/blog
http://niemeyer.net/twitter

[rsc, 2010-07-01 06:33:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=3db9a916a3fe ***

goinstall: support for Bazaar+Launchpad

With these changes, goinstall is now able to use branches
maintained with Bazaar located in Launchpad.

Project aliases such as /project and /project/series are
supported in addition to specific user or team branches
such as /~user/project/branch.  Temporary branches under
the +junk special project are also supported.

As a curious side effect, since Launchpad is able to import
code from other locations, they can be indirectly
accessible too if desired.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1699050

Committer: Russ Cox <rsc@golang.org>