Issue 1698044: code review 1698044: update protocol library to new reflection API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1698044: code review 1698044: update protocol library to new reflection API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by r

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, dsymonds2

Visibility:
Public.

Description

update protocol library to new reflection API. update golden files.

Patch Set 1 #

Patch Set 2 : code review 1698044: update protocol library to new reflection API. #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -97 lines)			Patch
M	compiler/testdata/test.pb.go.golden	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	proto/properties.go	View	5 chunks	+74 lines, -50 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	proto/testdata/test.pb.go.golden	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	proto/text.go	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	proto/text_parser.go	View	3 chunks	+39 lines, -38 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

15 years, 1 month ago (2010-06-22 00:48:00 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=b2001bd67179 ***

update protocol library to new reflection API.
update golden files.

R=rsc
CC=dsymonds
http://codereview.appspot.com/1698044

Expand All Messages | Collapse All Messages