Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 1692054: code review 1692054: fix disambiguation bug in enums from other packages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by r
Modified:
15 years, 1 month ago
Reviewers:
CC:
dsymonds
Visibility:
Public.

Description

fix disambiguation bug in enums from other packages. add .protodevel as a recognized extension.

Patch Set 1 #

Patch Set 2 : code review 1692054: fix disambiguation bug in enums from other packages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M compiler/generator/generator.go View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3
r
Hello dsymonds@golang.org, I'd like you to review this change.
15 years, 1 month ago (2010-07-16 22:48:12 UTC) #1
dsymonds
LGTM
15 years, 1 month ago (2010-07-17 02:33:07 UTC) #2
r
15 years, 1 month ago (2010-07-19 17:48:04 UTC) #3
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=91694341d313 ***

fix disambiguation bug in enums from other packages.
add .protodevel as a recognized extension.

R=dsymonds1
http://codereview.appspot.com/1692054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b