code review 1680044: reflect: add Kind, remove Int8Type, Int8Value, etc.

reflect: add Kind, remove Int8Type, Int8Value, etc.

update other code to match.

[rsc, 2010-06-19 01:59:35]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-06-19 03:21:16]

LGTM

bitsize and the gob check could be done in a separate CL

http://codereview.appspot.com/1680044/diff/5001/6015
File src/pkg/gob/type.go (right):

http://codereview.appspot.com/1680044/diff/5001/6015#newcode28
src/pkg/gob/type.go:28: func typeKind(typ reflect.Type) kind { return
kind(reflect.Typeof(typ)) }
is this needed now?  also the comment is wrong. i think it's a holdover

http://codereview.appspot.com/1680044/diff/5001/6021
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/1680044/diff/5001/6021#newcode236
src/pkg/reflect/type.go:236: type Kind uint8
needs a comment
be sure to say guaranteed never ==0

http://codereview.appspot.com/1680044/diff/5001/6021#newcode328
src/pkg/reflect/type.go:328: func (t *commonType) Size() uintptr { return t.size
}
probably worth having a BitSize

http://codereview.appspot.com/1680044/diff/5001/6025
File src/pkg/xml/read.go (right):

http://codereview.appspot.com/1680044/diff/5001/6025#newcode250
src/pkg/xml/read.go:250: *reflect.FloatValue, *reflect.BoolValue:
strange order, plus i'd just put them all on one line

[rsc, 2010-06-20 19:15:31]

done

On Fri, Jun 18, 2010 at 20:21,  <r@golang.org> wrote:
> LGTM
>
> bitsize and the gob check could be done in a separate CL
>
>
> http://codereview.appspot.com/1680044/diff/5001/6015
> File src/pkg/gob/type.go (right):
>
> http://codereview.appspot.com/1680044/diff/5001/6015#newcode28
> src/pkg/gob/type.go:28: func typeKind(typ reflect.Type) kind { return
> kind(reflect.Typeof(typ)) }
> is this needed now?  also the comment is wrong. i think it's a holdover
>
> http://codereview.appspot.com/1680044/diff/5001/6021
> File src/pkg/reflect/type.go (right):
>
> http://codereview.appspot.com/1680044/diff/5001/6021#newcode236
> src/pkg/reflect/type.go:236: type Kind uint8
> needs a comment
> be sure to say guaranteed never ==0
>
> http://codereview.appspot.com/1680044/diff/5001/6021#newcode328
> src/pkg/reflect/type.go:328: func (t *commonType) Size() uintptr {
> return t.size }
> probably worth having a BitSize
>
> http://codereview.appspot.com/1680044/diff/5001/6025
> File src/pkg/xml/read.go (right):
>
> http://codereview.appspot.com/1680044/diff/5001/6025#newcode250
> src/pkg/xml/read.go:250: *reflect.FloatValue, *reflect.BoolValue:
> strange order, plus i'd just put them all on one line
>
> http://codereview.appspot.com/1680044/show
>

[rsc, 2010-06-20 19:16:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=583685cffe54 ***

reflect: add Kind, remove Int8Type, Int8Value, etc.

update other code to match.

R=r
CC=golang-dev
http://codereview.appspot.com/1680044