Issue 1678046: code review 1678046: ld: fix implementation of -u

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1678046: code review 1678046: ld: fix implementation of -u (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : code review 1678046: ld: fix implementation of -u #

Total comments: 2

Patch Set 3 : code review 1678046: ld: fix implementation of -u #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -19 lines)			Patch
M	src/cmd/ld/go.c	View	1 2	5 chunks	+21 lines, -10 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1 2	2 chunks	+9 lines, -2 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1 2	8 chunks	+27 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-06-29 23:55:03 UTC) #1

LGTM http://codereview.appspot.com/1678046/diff/2001/3002 File src/cmd/ld/lib.c (right): http://codereview.appspot.com/1678046/diff/2001/3002#newcode340 src/cmd/ld/lib.c:340: tab http://codereview.appspot.com/1678046/diff/2001/3003 File src/cmd/ld/lib.h (right): http://codereview.appspot.com/1678046/diff/2001/3003#newcode92 src/cmd/ld/lib.h:92: void ...

15 years ago (2010-06-30 00:24:24 UTC) #2

rsc

15 years ago (2010-06-30 01:59:51 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e0a596daddd9 ***

ld: fix implementation of -u

R=r
CC=golang-dev
http://codereview.appspot.com/1678046

Expand All Messages | Collapse All Messages