Issue 1676044: Fixing IE racing issue test when popup opens multiple times

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1676044: Fixing IE racing issue test when popup opens multiple times (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by MohamedMansour

Modified:
13 years, 10 months ago

Reviewers:
nnaze, dan.pupius, nicholas.j.santos

Base URL:
http://closure-library.googlecode.com/svn/trunk/closure/

Visibility:
Public.

Fixing IE racing issue test when popup opens multiple times BUG=none TEST=run popupcolorpicker_test.html in IE/FF/Chrome

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	goog/ui/popupcolorpicker.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	goog/ui/popupcolorpicker_test.html	View		2 chunks	+10 lines, -10 lines	1 comment	Download

Total messages: 5

MohamedMansour

This solves the issue from http://codereview.appspot.com/1630041/show in IE where it removes the second test case. ...

13 years, 10 months ago (2010-06-15 00:01:10 UTC) #1

nick santos

just as an FYI, I'm not really qualified to review this change--I'm just the build ...

13 years, 10 months ago (2010-06-17 00:58:57 UTC) #2

nicholas.j.santos_gmail.com

oops, sorry, there's some terminology confusion--to be clear. I just patched this in to my ...

13 years, 10 months ago (2010-06-17 01:16:54 UTC) #3

nicholas.j.santos_gmail.com

13 years, 10 months ago (2010-06-17 17:30:15 UTC) #5

this should be in SVN now.

On Wed, Jun 16, 2010 at 9:19 PM,  <dan.pupius@gmail.com> wrote:
> LGTM
>
> http://codereview.appspot.com/1676044/show
>