Issue 167044: code review 167044: pick off special one-byte case in copy. worth 2x in ben...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 167044: code review 167044: pick off special one-byte case in copy. worth 2x in ben... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by r

Modified:
15 years, 7 months ago

Reviewers:
cw

CC:
rsc, golang-dev

Visibility:
Public.

Description

pick off special one-byte case in copy. worth 2x in benchmarks (38ns->16ns). the one-item case could be generalized easily with no cost. worth considering.

Patch Set 1 #

Patch Set 2 : code review 167044: pick off special one-byte case in copy. worth 2x in ben... #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/pkg/runtime/slice.c	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com, cw@f00f.org), I'd like you to review the following change.

15 years, 7 months ago (2009-12-07 18:51:57 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=8029cfdafa54 *** pick off special one-byte case in copy. worth 2x in ...

15 years, 7 months ago (2009-12-07 19:28:04 UTC) #3

15 years, 7 months ago (2009-12-07 19:29:15 UTC) #4

LGTM; the performance gap in my testing with this has narrowed.

Expand All Messages | Collapse All Messages