code review 166080: Added support for PE output.

Added support for PE output.

[hector, 2009-12-06 23:32:32]

Hello rsc,

I'd like you to review the following change.

[rsc, 2009-12-07 18:29:27]

looks very good.  a few small things below.
thanks.

http://codereview.appspot.com/166080/diff/16/1003
File src/cmd/8l/obj.c (right):

http://codereview.appspot.com/166080/diff/16/1003#newcode98
src/cmd/8l/obj.c:98: #ifdef __MINGW32__
This shouldn't be an #ifdef: the 8l on windows
should still be able to produce 8.out for other
systems.
Instead, I would suggest setting outfile = nil;
here and then below, before the switch on HEADTYPE, add

if(outfile == nil) {
    if(HEADTYPE == 10)
        outfile = "8.out.exe";
    else
        outfile = "8.out";
}

I also suggest 8.out.exe so that you still type 8.out
to run the binary.  "8" is a bit short.

http://codereview.appspot.com/166080/diff/16/1004
File src/cmd/8l/pass.c (right):

http://codereview.appspot.com/166080/diff/16/1004#newcode361
src/cmd/8l/pass.c:361: #ifdef __MINGW32__
This shouldn't be #ifdef.  It should check HEADTYPE == 10.
Also, this is pretty obscure and deserves a comment, like
// Convert 0(GS) into 0x2C(FS).

except that there is more going on here than I can
quite tell at this point.

http://codereview.appspot.com/166080/diff/16/1004#newcode370
src/cmd/8l/pass.c:370: p->from.type += D_FS-D_GS;
This can be p->from.type = D_INDIR+D_FS, right?

http://codereview.appspot.com/166080/diff/16/1004#newcode591
src/cmd/8l/pass.c:591: #ifdef __MINGW32__
if(HEADTYPE == 10) { ... } else { ... }

http://codereview.appspot.com/166080/diff/16/1005
File src/cmd/cc/lex.c (right):

http://codereview.appspot.com/166080/diff/16/1005#newcode43
src/cmd/cc/lex.c:43: #endif
#else
    return sys&Plan9;
#endif

might as well avoid a possible compiler warning

http://codereview.appspot.com/166080/diff/16/1006
File src/cmd/ld/pe.c (right):

http://codereview.appspot.com/166080/diff/16/1006#newcode24
src/cmd/ld/pe.c:24: static IMAGE_SECTION_HEADER *
A few style nits: s/ */*/ on this line.
Change "if (" to "if(" and "switch (" to "switch(" throughout.
Insert line breaks before function names below, as in

void
peinit(void)

etc.

[hector, 2009-12-12 17:43:18]

PTAL

[rsc, 2009-12-13 20:29:30]

LGTM

thanks

[rsc, 2009-12-13 20:36:35]

setting outfile = nil had its own problems.
i had to move the call to libinit down a bit.
before you run "hg sync" you should probably
run "hg revert src/cmd/8l/obj.c" or else you'll
get a merge conflict when you try to sync.

[rsc, 2009-12-13 20:39:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=1282de9807c6 ***

8l: add support for PE output.

R=rsc
http://codereview.appspot.com/166080

Committer: Russ Cox <rsc@golang.org>