Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 166072: code review 166072: test/bench: use range in reverse-complement (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by rsc
Modified:
15 years, 7 months ago
Reviewers:
CC:
r
Visibility:
Public.

Description

test/bench: use range in reverse-complement 1.9s gcc reverse-complement.c reverse-complement.go 4.5s / 3.5s original, with/without bounds checks 3.5s / 3.3s bounds check reduction 3.3s / 2.8s smarter garbage collector 2.6s / 2.3s assembler bytes.IndexByte 2.5s / 2.1s even smarter garbage collector 2.3s / 2.1s fix optimizer unnecessary spill bug 2.0s / 1.9s change loop to range (this CL)

Patch Set 1 #

Patch Set 2 : code review 166072: test/bench: use range in reverse-complement #

Patch Set 3 : code review 166072: test/bench: use range in reverse-complement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/bench/reverse-complement.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r, I'd like you to review the following change.
15 years, 7 months ago (2009-12-05 04:44:26 UTC) #1
r
LGTM
15 years, 7 months ago (2009-12-05 05:04:29 UTC) #2
rsc
15 years, 7 months ago (2009-12-05 05:44:31 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=6892511bb0df ***

test/bench: use range in reverse-complement

1.9s	gcc reverse-complement.c

reverse-complement.go
4.5s / 3.5s	original, with/without bounds checks
3.5s / 3.3s	bounds check reduction
3.3s / 2.8s	smarter garbage collector
2.6s / 2.3s	assembler bytes.IndexByte
2.5s / 2.1s	even smarter garbage collector
2.3s / 2.1s	fix optimizer unnecessary spill bug
2.0s / 1.9s	change loop to range (this CL)

R=r
http://codereview.appspot.com/166072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b