code review 165065: test/bench: dead code in reverse-complement

test/bench: dead code in reverse-complement

[rsc, 2009-12-05 03:21:01]

Hello r,

I'd like you to review the following change.

[r2, 2009-12-05 03:24:37]

LGTM

On Dec 4, 2009, at 7:21 PM, rsc@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r,
> 
> I'd like you to review the following change.
> 
> 
> Description:
> test/bench: dead code in reverse-complement
> 
> Please review this at http://codereview.appspot.com/165065
> 
> Affected files:
>  M test/bench/reverse-complement.go
> 
> 
> Index: test/bench/reverse-complement.go
> ===================================================================
> --- a/test/bench/reverse-complement.go
> +++ b/test/bench/reverse-complement.go
> @@ -61,37 +61,8 @@
> 	'N': 'N', 'n': 'N',
> }
> 
> -var in *bufio.Reader
> -
> -func reverseComplement(in []byte) []byte {
> -	outLen := len(in) + (len(in)+lineSize-1)/lineSize;
> -	out := make([]byte, outLen);
> -	j := 0;
> -	k := 0;
> -	for i := len(in) - 1; i >= 0; i-- {
> -		if k == lineSize {
> -			out[j] = '\n';
> -			j++;
> -			k = 0;
> -		}
> -		out[j] = complement[in[i]];
> -		j++;
> -		k++;
> -	}
> -	out[j] = '\n';
> -	j++;
> -	return out[0:j];
> -}
> -
> -func output(buf []byte) {
> -	if len(buf) == 0 {
> -		return
> -	}
> -	os.Stdout.Write(reverseComplement(buf));
> -}
> -
> func main() {
> -	in = bufio.NewReader(os.Stdin);
> +	in := bufio.NewReader(os.Stdin);
> 	buf := make([]byte, 1024*1024);
> 	line, err := in.ReadSlice('\n');
> 	for err == nil {
> @@ -113,6 +84,8 @@
> 				w += len(nbuf) - len(buf);
> 				buf = nbuf;
> 			}
> +
> +			// This loop is the bottleneck.
> 			for r := 0; r < len(line); r++ {
> 				w--;
> 				buf[w] = complement[line[r]];
> 
> 

[rsc, 2009-12-05 03:25:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=be1f5655f970 ***

test/bench: dead code in reverse-complement

R=r
http://codereview.appspot.com/165065