Issue 1641042: code review 1641042: Update the generator to the google-internal version.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1641042: code review 1641042: Update the generator to the google-internal version. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by r

Modified:
15 years, 2 months ago

Reviewers:

CC:
rsc, dsymonds

Visibility:
Public.

Description

Update the generator to the google-internal version. - a few changes to the plugin interface - handle situation where an imported package is called "proto" - use the file base name for the package name if a package is not specified

Patch Set 1 #

Patch Set 2 : code review 1641042: Update the generator to the google-internal version. #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -72 lines)			Patch
	M	compiler/generator/generator.go	View		22 chunks	+148 lines, -72 lines	0 comments	Download
	M	compiler/main.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

15 years, 2 months ago (2010-06-10 17:30:27 UTC) #4

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=37d24bb4be67 ***

Update the generator to the google-internal version.
- a few changes to the plugin interface
- handle situation where an imported package is called "proto"
- use the file base name for the package name if a package is not specified

R=rsc
CC=dsymonds1
http://codereview.appspot.com/1641042

Expand All Messages | Collapse All Messages