Issue 164090: code review 164090: minor improvement to formatting: don't allocate padding...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164090: code review 164090: minor improvement to formatting: don't allocate padding... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by r

Modified:
15 years, 7 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

minor improvement to formatting: don't allocate padding strings every time.

Patch Set 2 : code review 164090: minor improvement to formatting: don't allocate padding... #

Patch Set 3 : code review 164090: minor improvement to formatting: don't allocate padding... #

Patch Set 4 : code review 164090: minor improvement to formatting: don't allocate padding... #

Total comments: 1

Patch Set 5 : code review 164090: minor improvement to formatting: don't allocate padding... #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	src/pkg/fmt/format.go	View	1 2 3 4	2 chunks	+19 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/164090/diff/1007/1008 File src/pkg/fmt/format.go (right): http://codereview.appspot.com/164090/diff/1007/1008#newcode528 src/pkg/fmt/format.go:528: func init() { move up next to the ...

15 years, 7 months ago (2009-12-03 06:39:19 UTC) #2

15 years, 7 months ago (2009-12-03 08:04:42 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b4cfbaaf8aa6 ***

minor improvement to formatting: don't allocate padding strings every time.

R=rsc
http://codereview.appspot.com/164090

Expand All Messages | Collapse All Messages