Issue 164079: code review 164079: test that arrays work properly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164079: code review 164079: test that arrays work properly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by r

Modified:
15 years, 7 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

test that arrays work properly. can't mix slices and arrays now; perhaps that should be a TODO

Patch Set 2 : code review 164079: test that arrays work properly. #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	src/pkg/gob/encoder_test.go	View	1	1 chunk	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/164079/diff/1/2 File src/pkg/gob/encoder_test.go (right): http://codereview.appspot.com/164079/diff/1/2#newcode235 src/pkg/gob/encoder_test.go:235: if err := encAndDec(t4p, t4); err == nil ...

15 years, 7 months ago (2009-12-02 18:20:24 UTC) #2

15 years, 7 months ago (2009-12-02 18:25:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ad304e85e461 ***

test that arrays work properly.
can't mix slices and arrays now; perhaps that should be a TODO

R=rsc
http://codereview.appspot.com/164079

Expand All Messages | Collapse All Messages