code review 164059: make test.sh work again

make test.sh work again

[gri, 2009-12-01 19:00:50]

Hello rsc,

I'd like you to review the following change.

[gri, 2009-12-01 19:02:23]

PS: I am not sure why this stopped working, or why it worked before,
respectively.
- Robert

On Tuesday, December 1, 2009,  <gri@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc,
>
> I'd like you to review the following change.
>
>
> Description:
> make test.sh work again
>
> Please review this at http://codereview.appspot.com/164059
>
> Affected files:
>   M src/cmd/gofmt/test.sh
>
>
> Index: src/cmd/gofmt/test.sh
> ===================================================================
> --- a/src/cmd/gofmt/test.sh
> +++ b/src/cmd/gofmt/test.sh
> @@ -129,7 +129,7 @@
>
>
>  runtests() {
> -       if [ $# == 0 ]; then
> +       if [ "$*" == "" ]; then
>                 runtest apply
>                 # verify the pretty-printed files can be compiled with $GC
again
>                 # do it in local directory only because of the prerequisites
required
>
>
>

[rsc, 2009-12-01 19:37:58]

I think the correct test is

if [ $# = 0 ]; then

I don't think == should work either way
but maybe there is some GNU extension
as usual that makes == a synonym for =.

[gri, 2009-12-01 20:49:13]

PTAL

On Tuesday, December 1, 2009, Russ Cox <rsc@golang.org> wrote:
> I think the correct test is
>
> if [ $# = 0 ]; then

this won't work either.


>
> I don't think == should work either way
> but maybe there is some GNU extension
> as usual that makes == a synonym for =.
>

[rsc, 2009-12-01 21:05:27]

LGTM

hmm.  it probably has something to do with being
inside a function definition.   please change the
"$*" to "$@", which is like "$*" but avoids
reparsing the arguments and is the standard form
in this kind of situation.  (both on the line in
question and a few lines later.)

russ

[gri, 2009-12-01 21:08:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=f5fec2234289 ***

make test.sh work again

R=rsc
http://codereview.appspot.com/164059