Issue 163098: gc: handle _ = <-c in select.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 163098: gc: handle _ = <-c in select. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by rsc

Modified:
15 years, 5 months ago

Reviewers:
ken3

CC:
ken2

Visibility:
Public.

Description

gc: handle _ = <-c in select. Fixes issue 238.

Patch Set 1 #

Patch Set 2 : code review 163098: gc: handle _ = <-c in select. #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -4 lines)			Patch
M	src/cmd/gc/select.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug218.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	test/fixedbugs/bug225.go	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	test/golden.out	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=68ebc44e8429 *** gc: handle _ = <-c in select. Fixes issue 238. ...

15 years, 5 months ago (2009-12-03 09:30:22 UTC) #1

ken3

15 years, 5 months ago (2009-12-04 00:47:23 UTC) #2

On 2009/12/03 09:30:22, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=68ebc44e8429 ***
> 
> gc: handle _ = <-c in select.
> 
> Fixes issue 238.
> 
> R=ken2
> http://codereview.appspot.com/163098

LGTM

Expand All Messages | Collapse All Messages