Issue 163091: 8g: discard tempalloc/tempfree experiment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 163091: 8g: discard tempalloc/tempfree experiment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by rsc

Modified:
15 years, 5 months ago

Reviewers:
ken3

CC:
ken2

Visibility:
Public.

Description

8g: discard tempalloc/tempfree experiment in favor of tempname. allows optimizer to do more. unfortunately, optimizer seems to be broken; disable it.

Patch Set 1 #

Patch Set 2 : code review 163091: 8g: discard tempalloc/tempfree experiment #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -141 lines)			Patch
M	src/cmd/8g/cgen.c	View	16 chunks	+23 lines, -50 lines	0 comments	Download
M	src/cmd/8g/cgen64.c	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/cmd/8g/gg.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View	16 chunks	+13 lines, -26 lines	0 comments	Download
M	src/cmd/8g/gsubr.c	View	13 chunks	+18 lines, -54 lines	0 comments	Download
M	src/cmd/8g/opt.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=47a7d31e4405 *** 8g: discard tempalloc/tempfree experiment in favor of tempname. allows optimizer ...

15 years, 5 months ago (2009-12-03 02:31:32 UTC) #1

ken3

15 years, 5 months ago (2009-12-06 03:38:25 UTC) #2

On 2009/12/03 02:31:32, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=47a7d31e4405 ***
> 
> 8g: discard tempalloc/tempfree experiment
> in favor of tempname.
> allows optimizer to do more.
> unfortunately, optimizer seems to be broken; disable it.
> 
> R=ken2
> http://codereview.appspot.com/163091

LGTM

Expand All Messages | Collapse All Messages