Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(482)

Issue 1627042: code review 1627042: 8l: correct test for sp == top of stack in 8l -K code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by rsc
Modified:
15 years, 1 month ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

8l: correct test for sp == top of stack in 8l -K code

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/8l/pass.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 1 month ago (2010-06-11 23:17:43 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=d4d35397cb58 *** 8l: correct test for sp == top of stack in ...
15 years, 1 month ago (2010-06-11 23:17:53 UTC) #2
ken3
15 years, 1 month ago (2010-06-11 23:36:13 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b