Issue 162055: crypto/md4, exp/draw/x11: fix makefile to build when GO...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 162055: crypto/md4, exp/draw/x11: fix makefile to build when GO... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by sergio (larces)

Modified:
15 years, 7 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

crypto/md4, exp/draw/x11: fix makefile to build when GOROOT has whitespaces this is the exact same thing issue #115 is about. fix makefiles to use relative path to work in the case we have whitespaces as part of GOROOT.

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/crypto/md4/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/pkg/exp/draw/x11/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sergio (larces)

Hello, rsc. Please review this small change. thanks, sergio.

15 years, 7 months ago (2009-11-30 01:25:47 UTC) #1

rsc

LGTM sorry, these probably just crossed in the mail. i've got a build dashboard set ...

15 years, 7 months ago (2009-11-30 02:05:31 UTC) #2

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=4a2d56acb78e *** crypto/md4, exp/draw/x11: fix makefile to build when GOROOT has whitespaces ...

15 years, 7 months ago (2009-11-30 02:14:52 UTC) #3

Expand All Messages | Collapse All Messages