code review 162046: Added a method on UDPConn so they can actually send bro...

Added a method on UDPConn so they can actually send broadcast packets.

[runningwild, 2009-11-29 19:53:27]

Hello r (cc: gri),

I'd like you to review the following change.

[rsc, 2009-11-29 22:00:24]

Thanks.  Is there a reason to expose the method
instead of just always setting this flag?

[runningwild, 2009-11-30 01:42:36]

On 2009/11/29 22:00:24, rsc wrote:
> Thanks.  Is there a reason to expose the method
> instead of just always setting this flag?

Not sure.  I think it's considered a bit of a safety net to make sure that you
don't accidentally start flooding your network with packets.  I suppose it's
useful if you allow a user to enter an arbitrary address.  I don't mind changing
it, I just want to be able to broadcast packets :)

[rsc, 2009-11-30 02:14:10]

Ok, let's just set it all the time and not expose the method.
Keep the interface simple.

This is the same thing as in TCPConn: it sets NODELAY
all the time, because no one ever wants delay.

[runningwild, 2009-11-30 06:00:03]

On 2009/11/30 02:14:10, rsc wrote:
> Ok, let's just set it all the time and not expose the method.
> Keep the interface simple.
> 
> This is the same thing as in TCPConn: it sets NODELAY
> all the time, because no one ever wants delay.

Done.

[rsc, 2009-11-30 18:45:55]

LGTM

Thanks.  Could you please complete the CLA as
described at http://golang.org/doc/contribute.html#copyright ?
Don't worry about preparing an AUTHORS/CONTRIBUTORS CL -
we'll make the file modifications - just let me know once
you've completed the agreement.

Thanks.

[runningwild, 2009-11-30 19:02:09]

On 2009/11/30 18:45:55, rsc wrote:
> LGTM
> 
> Thanks.  Could you please complete the CLA as
> described at http://golang.org/doc/contribute.html#copyright ?
> Don't worry about preparing an AUTHORS/CONTRIBUTORS CL -
> we'll make the file modifications - just let me know once
> you've completed the agreement.
> 
> Thanks.

I've completed the agreement.

[rsc, 2009-11-30 20:03:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=14d035c58cdd ***

Added a method on UDPConn so they can actually send broadcast packets.

R=rsc
http://codereview.appspot.com/162046

Committer: Russ Cox <rsc@golang.org>