Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(567)

Issue 1616042: code review 1616042: Pad Go symbol table out to page boundary when linking d... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by iant
Modified:
15 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Pad Go symbol table out to page boundary when linking dynamically. This avoids a crash when using cgo where glibc's malloc thinks that it can use some of the memory following the symbol table. This fails because the symbol table is mapped read-only, which affects the whole page.

Patch Set 1 #

Patch Set 2 : code review 1616042: Pad Go symbol table out to page boundary when linking d... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/cmd/5l/asm.c View 2 chunks +4 lines, -2 lines 0 comments Download
M src/cmd/6l/asm.c View 2 chunks +4 lines, -2 lines 0 comments Download
M src/cmd/8l/asm.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 1 month ago (2010-06-11 20:33:52 UTC) #1
rsc1
LGTM
15 years, 1 month ago (2010-06-11 20:36:42 UTC) #2
iant
15 years, 1 month ago (2010-06-11 20:41:58 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3a800e823931 ***

Pad Go symbol table out to page boundary when linking dynamically.

This avoids a crash when using cgo where glibc's malloc thinks
that it can use some of the memory following the symbol table.
This fails because the symbol table is mapped read-only, which
affects the whole page.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1616042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b