Issue 161075: code review 161075: template: two bug fixes / nits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 161075: code review 161075: template: two bug fixes / nits (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by rsc

Modified:
15 years, 7 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

template: two bug fixes / nits * diagnose template not created with New (current code just crashes) * write []byte uninterpreted (current code writes fmt format: "[65 65 65 65]")

Patch Set 1 #

Patch Set 2 : code review 161075: template: two bug fixes / nits #

Patch Set 3 : code review 161075: template: two bug fixes / nits #

Patch Set 4 : code review 161075: template: two bug fixes / nits #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
M	src/pkg/template/format.go	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/template/template.go	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/template/template_test.go	View	2	4 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 7 months ago (2009-11-30 05:20:07 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=94ae1d9143b9 *** template: two bug fixes / nits * diagnose template not ...

15 years, 7 months ago (2009-11-30 18:29:18 UTC) #3

Expand All Messages | Collapse All Messages