Issue 161070: code review 161070: a[b:len(a)] -> a[b:]

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 161070: code review 161070: a[b:len(a)] -> a[b:] (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by _cw_

Modified:
15 years, 7 months ago

Reviewers:

CC:
r, rsc, agl1

Visibility:
Public.

Description

a[b:len(a)] -> a[b:]

Patch Set 1 #

Patch Set 2 : code review 161070: a[b:len(a)] -> a[b:] #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/pkg/crypto/tls/handshake_client.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/pkg/crypto/tls/handshake_messages.go	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

LGTM Thanks. These must have been in flight when we did the fix last time. ...

15 years, 7 months ago (2009-11-30 00:03:46 UTC) #2

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=f7d7d1515b46 *** a[b:len(a)] -> a[b:] R=r, rsc CC=agl1 http://codereview.appspot.com/161070 Committer: Russ Cox ...

15 years, 7 months ago (2009-11-30 20:03:46 UTC) #4

Expand All Messages | Collapse All Messages