code review 160065: fix weird all.bash failures by running deps.bash before...

fix weird all.bash failures by running deps.bash before make clean runs in pkg directory.
before this change, if pkg/Make.deps is missing or broken, clean.bash fails and the build dies
but not until much later.

add freebsd to error message about valid values of $GOOS

TODO: would be nice if this process exited when an error occurred. subshells make it hard

[r, 2009-11-25 04:52:57]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[rsc, 2009-11-25 04:56:13]

LGTM

in addition to this, src/pkg/Makefile should say
"-include" instead of "include".  the leading - means
"don't fail if this file isn't there".


On Tue, Nov 24, 2009 at 20:52,  <r@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> fix weird all.bash failures by running deps.bash before make clean runs
> in pkg directory.
> if pkg/Make.deps is missing or broken, clean.bash fails and the build
> dies.
>
> add freebsd to error message about valid values of $GOOS
>
> Please review this at http://codereview.appspot.com/160065
>
> Affected files:
>  M src/make.bash
>
>
> Index: src/make.bash
> ===================================================================
> --- a/src/make.bash
> +++ b/src/make.bash
> @@ -31,10 +31,10 @@
>  esac
>
>  case "$GOOS" in
> -darwin | linux | nacl | freebsd)
> +darwin | freebsd | linux | nacl)
>        ;;
>  *)
> -       echo '$GOOS is set to <'$GOOS'>, must be darwin, linux, or nacl'
> 1>&2
> +       echo '$GOOS is set to <'$GOOS'>, must be darwin, freebsd, linux, or
> nacl' 1>&2
>        exit 1
>  esac
>
> @@ -73,6 +73,10 @@
>        fi
>  fi
>
> +(
> +       cd pkg;
> +       bash deps.bash  # do this here so clean.bash will work in the pkg
> directory
> +)
>  bash clean.bash
>
>  for i in lib9 libbio libmach cmd pkg libcgo cmd/cgo cmd/ebnflint cmd/godoc
> cmd/gofmt cmd/goyacc cmd/hgpatch
> @@ -93,7 +97,6 @@
>                                bash make.bash
>                                ;;
>                        pkg)
> -                               bash deps.bash
>                                gomake install
>                                ;;
>                        *)
>
>
>

[r, 2009-11-25 05:07:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=73ca96fbb2b3 ***

fix weird all.bash failures by running deps.bash before make clean runs in pkg
directory.
before this change, if pkg/Make.deps is missing or broken, clean.bash fails and
the build dies
but not until much later.

add freebsd to error message about valid values of $GOOS

TODO: would be nice if this process exited when an error occurred. subshells
make it hard

R=rsc
CC=golang-dev
http://codereview.appspot.com/160065

[sergio (larces), 2009-11-25 05:17:11]

On 2009/11/25 05:07:09, r wrote:
> TODO: would be nice if this process exited when an error occurred. subshells
> make it hard
> 

can't we somehow use that 'set -e' option in here?

[r2, 2009-11-25 05:21:13]

On Nov 24, 2009, at 9:17 PM, sergio@larces.uece.br wrote:

> On 2009/11/25 05:07:09, r wrote:
>> TODO: would be nice if this process exited when an error occurred.
> subshells
>> make it hard
>
>
> can't we somehow use that 'set -e' option in here?
>
> http://codereview.appspot.com/160065

it is set but -e is not inherited by subshells.  if you want to  
experiment i'm happy to do a code review.

-rob