code review 160061: add freebsd to the list of os'es.

add freebsd to the list of os'es.
make the GOOS/GOARCH pair a table to avoid the confusion caused when it was of the form linux/386.

[r, 2009-11-24 23:52:20]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[rsc, 2009-11-24 23:57:03]

LGTM but sort the table rows

[r, 2009-11-25 00:00:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=a50ca422003f ***

add freebsd to the list of os'es.
make the GOOS/GOARCH pair a table to avoid the confusion caused when it was of
the form linux/386.

R=rsc
CC=golang-dev
http://codereview.appspot.com/160061

[Eric Rannaud, 2009-11-25 04:21:09]

On 2009/11/25 00:00:21, r wrote:
> add freebsd to the list of os'es.
> make the GOOS/GOARCH pair a table to avoid the confusion caused when it was of
> the form linux/386.

You may want to include the following patch: the first change just reorder the
list in alphabetical order, the second change adds freebsd to the help message.


diff -r 2b13a45c7c91 src/make.bash
--- a/src/make.bash     Tue Nov 24 17:34:08 2009 -0800
+++ b/src/make.bash     Tue Nov 24 20:18:12 2009 -0800
@@ -31,10 +31,10 @@
 esac

 case "$GOOS" in
-darwin | linux | nacl | freebsd)
+darwin | freebsd | linux | nacl)
        ;;
 *)
-       echo '$GOOS is set to <'$GOOS'>, must be darwin, linux, or nacl' 1>&2
+       echo '$GOOS is set to <'$GOOS'>, must be darwin, freebsd, linux, or
nacl' 1>&2
        exit 1
 esac

[r2, 2009-11-25 04:25:05]

thanks, got it.

-rob

On Nov 24, 2009, at 8:21 PM, eric.rannaud@gmail.com wrote:

> On 2009/11/25 00:00:21, r wrote:
>> add freebsd to the list of os'es.
>> make the GOOS/GOARCH pair a table to avoid the confusion caused when
> it was of
>> the form linux/386.
>
> You may want to include the following patch: the first change just
> reorder the list in alphabetical order, the second change adds freebsd
> to the help message.
>
>
> diff -r 2b13a45c7c91 src/make.bash
> --- a/src/make.bash     Tue Nov 24 17:34:08 2009 -0800
> +++ b/src/make.bash     Tue Nov 24 20:18:12 2009 -0800
> @@ -31,10 +31,10 @@
> esac
>
> case "$GOOS" in
> -darwin | linux | nacl | freebsd)
> +darwin | freebsd | linux | nacl)
>        ;;
> *)
> -       echo '$GOOS is set to <'$GOOS'>, must be darwin, linux, or  
> nacl'
> 1>&2
> +       echo '$GOOS is set to <'$GOOS'>, must be darwin, freebsd,  
> linux,
> or nacl' 1>&2
>        exit 1
> esac
>
>
>
> http://codereview.appspot.com/160061