code review 159051: Provides implementation of MD4 hashing algorithm.

Provides implementation of MD4 hashing algorithm.

See IETF RFC 1320, http://tools.ietf.org/html/rfc1320.
Fixes issue 279.

[calennert, 2009-11-22 19:54:10]

Hello rsc,

I'd like you to review the following change.

[rsc, 2009-11-23 22:07:33]

Thanks for sending this in.  Could you please 
also send a CL updating CONTRIBUTORS and AUTHORS
as per http://golang.org/doc/contribute.html#copyright ?

Thanks.

[rsc, 2009-11-23 22:13:22]

LGTM

The code looks great.  After making the change below
please run "hg upload" to re-upload the CL to the 
review server.

Once I get the CL with the AUTHORS and CONTRIBUTORS
changes and verify that you've filled out the CLA form,
I will submit this.

Thanks again.

http://codereview.appspot.com/159051/diff/1001/16
File src/pkg/crypto/md4/md4block.go (right):

http://codereview.appspot.com/159051/diff/1001/16#newcode76
src/pkg/crypto/md4/md4block.go:76: p = p[_Chunk:len(p)];
Please change to

p = p[_Chunk:];

(You'll have to run "hg pull -u" and re-run ./all.bash
to be able to use this syntax.)

[calennert, 2009-11-23 23:58:40]

> http://codereview.appspot.com/159051/diff/1001/16#newcode76
> src/pkg/crypto/md4/md4block.go:76: p = p[_Chunk:len(p)];
> Please change to
> 
> p = p[_Chunk:];
Assuming the new notation was preferred, I took the liberty of making similar
changes to md4.go (2 lines).

Individual CLA submitted. CL 160047 with changes to AUTHORS and CONTRIBUTORS
submitted.

Take care, 
Chris

[rsc, 2009-11-24 01:44:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=7c34597c3375 ***

Provides implementation of MD4 hashing algorithm.

See IETF RFC 1320, http://tools.ietf.org/html/rfc1320.
Fixes issue 279.

R=rsc
http://codereview.appspot.com/159051

Committer: Russ Cox <rsc@golang.org>