Issue 157062: code review 157062: big: implement 386 assembly routines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157062: code review 157062: big: implement 386 assembly routines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by rsc

Modified:
15 years, 7 months ago

Reviewers:
agl1

CC:
golang-dev, gri

Visibility:
Public.

Description

big: implement 386 assembly routines 7x speedup on big and crypto/rsa unit tests. also dropped useAsm in favor of making the asm stubs jump to the Go versions.

Patch Set 2 : code review 157062: big: implement 386 assembly routines #

Total comments: 1

Patch Set 3 : code review 157062: big: implement 386 assembly routines #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -29 lines)			Patch
M	src/pkg/big/arith.go	View		1 chunk	+11 lines, -13 lines	0 comments	Download
M	src/pkg/big/arith_386.s	View	1 2	1 chunk	+158 lines, -4 lines	0 comments	Download
M	src/pkg/big/arith_amd64.s	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/pkg/big/arith_arm.s	View	1 2	1 chunk	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello agl1 (cc: golang-dev@googlegroups.com, gri), I'd like you to review the following change.

15 years, 7 months ago (2009-11-18 08:20:47 UTC) #1

agl1

LGTM http://codereview.appspot.com/157062/diff/1001/10 File src/pkg/big/arith.go (right): http://codereview.appspot.com/157062/diff/1001/10#newcode303 src/pkg/big/arith.go:303: //return; We seem to have the worst of ...

15 years, 7 months ago (2009-11-18 17:51:15 UTC) #2

rsc

15 years, 7 months ago (2009-11-18 17:54:53 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=de00a1e262a7 ***

big: implement 386 assembly routines
7x speedup on big and crypto/rsa unit tests.
also dropped useAsm in favor of making the
asm stubs jump to the Go versions.

R=agl1
CC=golang-dev, gri
http://codereview.appspot.com/157062

Expand All Messages | Collapse All Messages