Issue 157060: code review 157060: cgo no longer translates function args that are void* into

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157060: code review 157060: cgo no longer translates function args that are void* into (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by eden.li

Modified:
15 years, 8 months ago

Reviewers:
rsc

Visibility:
Public.

Description

cgo no longer translates function args that are void* into unsafe.Pointer. Fixes issue 254.

Patch Set 1 #

Patch Set 2 : code review 157060: cgo no longer translates function args that are void* into #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/cmd/cgo/gcc.go	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

eden.li

Hello rsc (cc: eden.li), I'd like you to review the following change.

15 years, 8 months ago (2009-11-18 07:14:03 UTC) #1

rsc

Thanks for looking at this. The change looks good, but I need you to send ...

15 years, 8 months ago (2009-11-18 07:24:54 UTC) #2

rsc

15 years, 8 months ago (2009-11-18 07:42:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e2c22c54855c ***

cgo no longer translates function args that are void* into
unsafe.Pointer.
Fixes issue 254.

R=rsc
http://codereview.appspot.com/157060

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages