Issue 156113: code review 156113: FreeBSD's mcontext isn't exactly the same as sigcontext, so

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156113: code review 156113: FreeBSD's mcontext isn't exactly the same as sigcontext, so (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by dho

Modified:
15 years, 7 months ago

Reviewers:
wjosephson, rsc

CC:
golang-dev

Visibility:
Public.

Description

FreeBSD's mcontext isn't exactly the same as sigcontext, so we can't use them interchangably.

Patch Set 1 #

Patch Set 2 : code review 156113: FreeBSD's mcontext isn't exactly the same as sigcontext, so #

Patch Set 3 : code review 156113: FreeBSD's mcontext isn't exactly the same as sigcontext, so #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -122 lines)			Patch
M	src/pkg/runtime/freebsd/386/defs.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	src/pkg/runtime/freebsd/386/signal.c	View	4 chunks	+17 lines, -19 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/defs.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/signal.c	View	4 chunks	+26 lines, -28 lines	0 comments	Download
M	src/pkg/runtime/freebsd/defs.c	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dho

Hello rsc, wjosephson (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 7 months ago (2009-11-20 16:09:02 UTC) #1

wjosephson

On 2009/11/20 16:09:02, dho wrote: > Hello rsc, wjosephson (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...

15 years, 7 months ago (2009-11-20 16:18:31 UTC) #2

dho

On 2009/11/20 16:18:31, wjosephson wrote: > On 2009/11/20 16:09:02, dho wrote: > > Hello rsc, ...

15 years, 7 months ago (2009-11-20 16:19:33 UTC) #3

wjosephson

On 2009/11/20 16:19:33, dho wrote: > > Any reason to keep the definition of Sigcontext ...

15 years, 7 months ago (2009-11-20 16:21:02 UTC) #4

rsc

15 years, 7 months ago (2009-11-20 21:08:20 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=ba2c07fe2d77 ***

FreeBSD's mcontext isn't exactly the same as sigcontext, so
we can't use them interchangably.

R=rsc, wjosephson
CC=golang-dev
http://codereview.appspot.com/156113

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages