Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 156110: code review 156110: test/bench revisions; (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by rsc
Modified:
15 years, 7 months ago
Reviewers:
r
Visibility:
Public.

Description

test/bench revisions; * reverse-complement: port C algorithm to Go saves 30% on my MacBook Pro and makes it a fairer comparison. * test reverse-complement with and without GC (another 15%) * revise timing.sh to work on more systems * avoid two glibcisms in fasta.c

Patch Set 1 #

Patch Set 2 : code review 156110: test/bench revisions; #

Patch Set 3 : code review 156110: test/bench revisions; #

Patch Set 4 : code review 156110: test/bench revisions; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M test/bench/fasta.c View 3 chunks +5 lines, -5 lines 0 comments Download
M test/bench/reverse-complement.go View 1 chunk +34 lines, -22 lines 0 comments Download
M test/bench/timing.sh View 1 2 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r, I'd like you to review the following change.
15 years, 7 months ago (2009-11-20 08:26:04 UTC) #1
r
LGTM
15 years, 7 months ago (2009-11-20 16:25:50 UTC) #2
rsc
15 years, 7 months ago (2009-11-20 16:59:13 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d8167387e008 ***

test/bench revisions;
  * reverse-complement: port C algorithm to Go
	saves 30% on my MacBook Pro and makes it a fairer comparison.
  * test reverse-complement with and without GC (another 15%)
  * revise timing.sh to work on more systems
  * avoid two glibcisms in fasta.c

R=r
http://codereview.appspot.com/156110
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b