Issue 156094: code review 156094: - flip in and out to exercise overlap check a little (c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156094: code review 156094: - flip in and out to exercise overlap check a little (c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by r

Modified:
15 years, 6 months ago

Reviewers:
ken2, rsc

CC:
golang-dev_googlegroups.org

Visibility:
Public.

Description

- flip in and out to exercise overlap check a little (could do better) - actually test the results

Patch Set 2 : code review 156094: - flip in and out to exercise overlap check a little (c... #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -25 lines)			Patch
	M	test/copy.go	View	1	7 chunks	+125 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc, ken2 (cc: golang-dev@googlegroups.org), I'd like you to review the following change.

15 years, 6 months ago (2009-11-19 04:59:57 UTC) #1

rsc

LGTM http://codereview.appspot.com/156094/diff/1/2 File test/copy.go (right): http://codereview.appspot.com/156094/diff/1/2#newcode98 test/copy.go:98: copy(output8[out:clamp(out+length)], input8[in:clamp(in+length)]); n := copy ... and pass ...

15 years, 6 months ago (2009-11-19 05:58:41 UTC) #2

15 years, 6 months ago (2009-11-19 06:26:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b6f562f9b183 ***

- flip in and out to exercise overlap check a little (could do better)
- actually test the results

R=rsc, ken2
CC=golang-dev
http://codereview.appspot.com/156094

Expand All Messages | Collapse All Messages