Issue 156086: code review 156086: bugs in memmove:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156086: code review 156086: bugs in memmove: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by r

Modified:
15 years, 7 months ago

Reviewers:
ken2, rsc

Visibility:
Public.

Description

bugs in memmove: - has arguments (no stack split) - MOVL does not set condition

Patch Set 1 #

Patch Set 2 : code review 156086: bugs in memmove: #

Patch Set 3 : code review 156086: bugs in memmove: #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	src/pkg/runtime/386/memmove.s	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/amd64/memmove.s	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/arm/memmove.s	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

15 years, 7 months ago (2009-11-18 23:00:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ce8296a8e6ae ***

bugs in memmove:
	- has arguments (no stack split)
	- MOVL does not set condition

R=ken2, rsc
http://codereview.appspot.com/156086

Expand All Messages | Collapse All Messages