code review 155061: - Clarify that struct composite literal keys are field ...

- Clarify that struct composite literal keys are field names not selectors.
- Slight re-phrasing of struct type section since "field name" was not
properly introduced.

Fixes issue 164.

[gri, 2009-11-16 00:39:32]

Hello r, rsc, iant,

I'd like you to review the following change.

[iant, 2009-11-16 05:45:31]

LGTM

[r, 2009-11-16 07:12:33]

LGTM but please see comment

http://codereview.appspot.com/155061/diff/1004/5
File doc/go_spec.html (right):

http://codereview.appspot.com/155061/diff/1004/5#newcode1920
doc/go_spec.html:1920: it is not a <a href="#Selectors">selector</a>.
i'd drop the second line.  the first is clear enough given the terms you've
defined. the second overexplains

[rsc, 2009-11-16 16:13:55]

LGTM

http://codereview.appspot.com/155061/diff/1004/5
File doc/go_spec.html (right):

http://codereview.appspot.com/155061/diff/1004/5#newcode698
doc/go_spec.html:698: A struct type declares a <i>field name</i> and type for
each field; field
If you only read half this sentence
(A struct type declares a field name) you get very confused.
Can merge with last sentence and avoid this:

A struct is a sequence of named elements, called fields, each of which has a
name and a type.
Field names may be ...

http://codereview.appspot.com/155061/diff/1004/5#newcode699
doc/go_spec.html:699: names may be specified explicitly (IdentifierList), or
implicitly (AnonymousField).
drop comma

[gri, 2009-11-16 16:59:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=57c2810ca63f ***

- Clarify that struct composite literal keys are field names not selectors.
- Slight re-phrasing of struct type section since "field name" was not
properly introduced.

Fixes issue 164.

R=r, rsc, iant
http://codereview.appspot.com/155061