Issue 155056: code review 155056: fix bug in bytes.Map and add test cases for Map in both...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 155056: code review 155056: fix bug in bytes.Map and add test cases for Map in both... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by r

Modified:
15 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

fix bug in bytes.Map and add test cases for Map in both strings and bytes packages. thanks to ulrik.sverdrup for the test case. Fixes issue 191.

Patch Set 2 : code review 155056: fix bug in bytes.Map and add test cases for Map in both... #

Patch Set 3 : code review 155056: fix bug in bytes.Map and add test cases for Map in both... #

Total comments: 1

Patch Set 4 : code review 155056: fix bug in bytes.Map and add test cases for Map in both... #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -3 lines)			Patch
M	src/pkg/bytes/bytes.go	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/pkg/bytes/bytes_test.go	View	1	3 chunks	+28 lines, -0 lines	0 comments	Download
M	src/pkg/strings/strings_test.go	View	1 2	3 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 8 months ago (2009-11-15 19:54:48 UTC) #1

rsc

LGTM http://codereview.appspot.com/155056/diff/12/1005 File src/pkg/bytes/bytes.go (right): http://codereview.appspot.com/155056/diff/12/1005#newcode223 src/pkg/bytes/bytes.go:223: if rune < utf8.RuneSelf { fine as is. ...

15 years, 8 months ago (2009-11-15 20:01:07 UTC) #2

15 years, 8 months ago (2009-11-15 20:07:30 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fd9c2e514c03 ***

fix bug in bytes.Map and add test cases for Map in both strings and bytes
packages.
thanks to ulrik.sverdrup for the test case.

Fixes issue 191.

R=rsc
CC=golang-dev
http://codereview.appspot.com/155056

Expand All Messages | Collapse All Messages