Lilypond-book: Factor out the formatting from lilypond-book into separate classes

Lilypond-book: Factor out the formatting from lilypond-book into separate classes

[Carl, 2010-06-07 19:45:30]

Looks nicely done to me.  It was a big job!

Thanks,

Carl

[Graham Percival (old account), 2010-06-08 13:02:51]

Looks good to me; it compiles cleanly from scratch, and all doc formats look
normal.
(I couldn't check images inside info, since I don't know how to display those)

[Neil Puttock, 2010-06-10 19:01:03]

Hi Reinhold,

LGTM.

Images inside info are all present and correct (using emacs).

Cheers,
Neil

http://codereview.appspot.com/1543042/diff/17001/18007
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/1543042/diff/17001/18007#newcode207
scripts/lilypond-book.py:207: group = OptionGroup (p, "Options only for the
latex and texinfo backends")
Is it possible to fix the indentation for this group?

The formatter overload in lilylib.py doesn't seem to affect the extra
indentation for these options (help output below, starting with --warranty for
indent reference)

   -w, --warranty       show warranty and copyright

Options only for the latex and texinfo backends:
         --latex-program=PROG
                        run executable PROG instead of latex, or in case --pdf
                        option is set instead of pdflatex
         --pdf          create PDF files for use with PDFTeX

[Reinhold, 2010-06-11 11:59:11]

http://codereview.appspot.com/1543042/diff/17001/18007
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/1543042/diff/17001/18007#newcode207
scripts/lilypond-book.py:207: group = OptionGroup (p, "Options only for the
latex and texinfo backends")
On 2010/06/10 19:01:04, Neil Puttock wrote:
> Is it possible to fix the indentation for this group?
> 
> The formatter overload in lilylib.py doesn't seem to affect the extra
> indentation for these options (help output below, starting with --warranty for
> indent reference)

Well, the actual problem is that we tweak the formatter to not indent the
headings, but the options are not changed in lilylib.py. By default, the group
header would also be indented, which makes more sense...

Anyway, I have now tweaked our own NonDentedHeadingFormatter class to use only
one level of indentation, even if we have several nested groups (the headings
were not indented anyway, so the hierarchy wouldn't be properly visile anyway).

[Graham Percival, 2010-06-11 12:59:27]

On Fri, Jun 11, 2010 at 12:59 PM,  <reinhold.kainhofer@gmail.com> wrote:
>
> Please review this at http://codereview.appspot.com/1543042/show

I think you pushed it to master accidentally.  But I'm checking to see
if it compiles right now; if it works, let's just leave it there
instead of reverting, and make any necessary changes later.

Cheers,
- Graham

[reinhold_kainhofer.com, 2010-06-11 13:21:18]

Am Freitag, 11. Juni 2010, 14:59:23 schrieb Graham Percival:
> On Fri, Jun 11, 2010 at 12:59 PM,  <reinhold.kainhofer@gmail.com> wrote:
> > Please review this at http://codereview.appspot.com/1543042/show
> 
> I think you pushed it to master accidentally.

No, not accidentally. You said "LGTM" and Neil confirmed this and asserted 
that info images also looked fine, so I commited it.
I pushed it after fixing the only complaint about option display with --help.

Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org

[Graham Percival, 2010-06-11 13:27:44]

On Fri, Jun 11, 2010 at 2:21 PM, Reinhold Kainhofer
<reinhold@kainhofer.com> wrote:
> Am Freitag, 11. Juni 2010, 14:59:23 schrieb Graham Percival:
>> On Fri, Jun 11, 2010 at 12:59 PM,  <reinhold.kainhofer@gmail.com> wrote:
>> > Please review this at http://codereview.appspot.com/1543042/show
>>
>> I think you pushed it to master accidentally.
>
> No, not accidentally. You said "LGTM" and Neil confirmed this and asserted
> that info images also looked fine, so I commited it.
> I pushed it after fixing the only complaint about option display with --help.

err... ok.  Google mail received an email from you at 12:59 (it's now
14:26) saying "please review this at..."  oh, wait!  Does the
codereview website automatically append that to emails?  That would
make sense, and would explain everything!

Cheers,
- Graham