Issue 154167: code review 154167: Add id attribute to h2 and h3 tags so that they exist w...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154167: code review 154167: Add id attribute to h2 and h3 tags so that they exist w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by gri

Modified:
15 years, 7 months ago

Reviewers:
rsc

Visibility:
Public.

Description

Add id attribute to h2 and h3 tags so that they exist when referring to generated pages even if Javascript has not introduced them yet.

Patch Set 2 : code review 154167: Add id attribute to h2 and h3 tags so that they exist w... #

Total comments: 2

Patch Set 3 : code review 154167: Add id attribute to h2 and h3 tags so that they exist w... #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	lib/godoc/package.html	View		3 chunks	+8 lines, -8 lines	0 comments	Download
	M	lib/godoc/search.html	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/154167/diff/1001/1003 File lib/godoc/search.html (right): http://codereview.appspot.com/154167/diff/1001/1003#newcode25 lib/godoc/search.html:25: <h3 id="Global {Pak.Path|path}">package <a href="{Pak.Path|path}">{Pak.Name|html}</a></h3> after Global change ...

15 years, 7 months ago (2009-11-16 23:22:57 UTC) #2

gri

15 years, 7 months ago (2009-11-16 23:25:19 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7a1fc1bfd8a6 ***

Add id attribute to h2 and h3 tags so that they exist when referring
to generated pages even if Javascript has not introduced them yet.

R=rsc
http://codereview.appspot.com/154167

Expand All Messages | Collapse All Messages