Issue 154126: code review 154126: xml: Fixed CDATA parsing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154126: code review 154126: xml: Fixed CDATA parsing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by abhinavg

Modified:
15 years, 8 months ago

Reviewers:
r, rsc

Visibility:
Public.

Description

xml: Fixed CDATA parsing. Fixes issue 128.

Patch Set 1 : code review 154126: xml: Fixed CDATA parsing. #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/xml/xml.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

abhinavg

Hello r, rsc, I'd like you to review the following change.

15 years, 8 months ago (2009-11-14 00:50:50 UTC) #1

rsc

This looks great; could you please create a separate CL with AUTHORS and CONTRIBUTORS changes ...

15 years, 8 months ago (2009-11-14 01:39:57 UTC) #2

abhinavg

On 2009/11/14 01:39:57, rsc wrote: > This looks great; could you please create a separate ...

15 years, 8 months ago (2009-11-14 02:26:40 UTC) #3

rsc

15 years, 8 months ago (2009-11-14 19:46:10 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=703fb2c605af ***

	xml: Fixed CDATA parsing.

    Fixes issue 128.

R=r, rsc
http://codereview.appspot.com/154126

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages