code review 154123: Syntax coloring and function navigation for BBEdit/Text...

Syntax coloring and function navigation for BBEdit/TextWrangler

[ajstarks, 2009-11-13 23:24:22]

Hello rsc,

I'd like you to review the following change.

[rsc, 2009-11-13 23:43:32]

Thanks.
Seems reasonable; please move to a subdirectory of misc.

cd $GOROOT/misc
mkdir bbedit
cp Go.plist bbedit/Go.plist
hg add bbedit/Go.plist  # add to hg
hg file 154123 bbedit/Go.plist   # assign to this CL
hg file -d 154123 Go.plist   # take Go.plist out
hg revert Go.plist   # and revert it

I don't think you meant to include doc/htmlgen:

cd $GOROOT
hg file -d 154123 doc/htmlgen  # take out of this CL

And then hg upload.

Also, please follow the copyright section at
http://golang.org/doc/contribute.html#copyright
(if you have done this already, my apologies;
please remind me what the CL number is).

[rsc, 2009-11-13 23:46:19]

Adding agl to keep him in the loop.

[rsc, 2009-11-30 22:53:32]

ajstarks: are you still interested in getting this
into the distribution?

[ajstarks, 2009-12-01 00:06:03]

sure. is there anything I need to do?

On Nov 30, 2009, at 5:53 PM, rsc@golang.org wrote:

> ajstarks: are you still interested in getting this
> into the distribution?
> 
> 
> 
> http://codereview.appspot.com/154123

[agl1, 2009-12-01 00:09:15]

On Mon, Nov 30, 2009 at 4:05 PM, Anthony Starks <ajstarks@gmail.com> wrote:
> sure. is there anything I need to do?

I think rsc was waiting on the copyright stuff if you've not already done it:

http://golang.org/doc/contribute.html#copyright


AGL

[rsc, 2009-12-01 00:14:37]

On Mon, Nov 30, 2009 at 16:05, Anthony Starks <ajstarks@gmail.com> wrote:
> sure. is there anything I need to do?

see the comments in the messages section of
http://codereview.appspot.com/154123

[ajstarks, 2009-12-01 00:18:38]

On 2009/12/01 00:14:37, rsc wrote:
> On Mon, Nov 30, 2009 at 16:05, Anthony Starks <mailto:ajstarks@gmail.com>
wrote:
> > sure. is there anything I need to do?
> 
> see the comments in the messages section of
> http://codereview.appspot.com/154123
> 

just signed up for the individual copyright license

[rsc, 2009-12-01 00:27:05]

thanks.  one more thing.
the top of Go.plist should have a copyright
notice, like any of the other files

// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

(the comment character might be different, i don't know.)

please make that change, hg upload, and let us know.

[rsc, 2009-12-01 03:24:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=9abd10c4e993 ***

Syntax coloring and function navigation for BBEdit/TextWrangler

R=rsc
CC=agl1
http://codereview.appspot.com/154123

Committer: Russ Cox <rsc@golang.org>