code review 154096: Correct indentation for go-mode where a close brace fol...

Correct indentation for go-mode where a close brace following a semi-
colon-less statement would be indented one stop too many.

[JamesAguilar, 2009-11-12 22:13:05]

Hello rsc,

I'd like you to review the following change.

[rsc, 2009-11-12 22:16:40]

Austin, can you review this for me?

[aclements, 2009-11-13 18:18:39]

On 2009/11/12 22:16:40, rsc wrote:
> Austin, can you review this for me?

Mostly looks good.  It incorrectly indents case/default following a
semi-colon-less statement, but that's pretty easy to fix.  Move the setq
current-line-closes-scope above the case/default/label outdenting code and setq
current-line-closes-scope to t in the case/default/label outdenting code:

          (setq current-line-closes-scope
                (case (char-after)
                  ((?\} ?\)) t)
                  (t nil)))

          ;; case, default, and labels are outdented 1 level
          (when (looking-at "\\<case\\>\\|\\<default\\>\\|\\w+\\s
*:\\(\\S.\\|$\\)")
            (decf indent tab-width)
            ;; In case this case/etc follows a statement that is not
            ;; ;-terminated, make sure we still outdent it.
            (setq current-line-closes-scope t))

[aclements, 2009-11-13 21:23:57]

LGTM

[rsc, 2009-11-13 23:52:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=a6abd43d6e10 ***

Correct indentation for go-mode where a close brace following a semi-
colon-less statement would be indented one stop too many.

R=rsc, aclements
CC=aclements
http://codereview.appspot.com/154096

Committer: Russ Cox <rsc@golang.org>

[rsc, 2009-11-23 23:40:57]

James-
Please run "hg sync" so that your client will mark
this CL as closed.
Thanks.

[JamesAguilar, 2009-11-24 02:10:23]

On 2009/11/23 23:40:57, rsc wrote:
> James-
> Please run "hg sync" so that your client will mark
> this CL as closed.
> Thanks.

Done. Sorry, I didn't realize any further action was necessary from me.

[JamesAguilar, 2009-11-24 02:13:03]

On 2009/11/24 02:10:23, JamesAguilar wrote:
> On 2009/11/23 23:40:57, rsc wrote:
> > James-
> > Please run "hg sync" so that your client will mark
> > this CL as closed.
> > Thanks.
> 
> Done. Sorry, I didn't realize any further action was necessary from me.

Hmm . . . as far as I can tell, the issue is still open after I ran hg sync.
Should I close it manually through the web interface or is there something else
I might need to do?

[rsc, 2009-11-24 02:21:39]

there has been too much activity!
the plugin only looks at the last 100 log entries
to find things to close.

you can close this manually by visiting
http://codereview.appspot.com/154096 and
clicking on the "x in a circle" icon next
to the headline.

thanks.
russ