Issue 152123: json: fix addressing of slice indexes that are multiple...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152123: json: fix addressing of slice indexes that are multiple... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by agl1

Modified:
15 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

json: fix addressing of slice indexes that are multiples of 8. Fixes issue 147.

Patch Set 1 #

Patch Set 2 : code review 152123: json: fix addressing of slice indexes that are multiple... #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
	M	src/pkg/json/struct.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/json/struct_test.go	View	1	2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

I tend to err on the side of more tests, but it's not entirely clear ...

15 years, 7 months ago (2009-11-13 19:24:34 UTC) #1

agl1

15 years, 7 months ago (2009-11-13 19:29:16 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=66621dd2e8fa ***

json: fix addressing of slice indexes that are multiples of 8.

Fixes issue 147.

R=rsc
CC=golang-dev
http://codereview.appspot.com/152123

Expand All Messages | Collapse All Messages