Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(518)

Issue 152088: code review 152088: gopack: work around gcc bug in hash function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by rsc
Modified:
16 years, 1 month ago
Reviewers:
r, r1
Visibility:
Public.

Description

gopack: work around gcc bug in hash function Fixes issue 48. (this time for sure!)

Patch Set 1 #

Patch Set 2 : code review 152088: gopack: work around gcc bug in hash function #

Patch Set 3 : code review 152088: gopack: work around gcc bug in hash function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/cmd/gopack/ar.c View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r, I'd like you to review the following change.
16 years, 1 month ago (2009-11-12 05:54:22 UTC) #1
r1
nice
16 years, 1 month ago (2009-11-12 05:59:46 UTC) #2
r1
LGTM i mean
16 years, 1 month ago (2009-11-12 05:59:57 UTC) #3
rsc
16 years, 1 month ago (2009-11-12 06:19:59 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=a1911e0a0430 ***

gopack: work around gcc bug in hash function

Fixes issue 48.  (this time for sure!)

R=r, r1
http://codereview.appspot.com/152088
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b