Issue 152072: code review 152072: use fully qualified names for hash interfaces

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152072: code review 152072: use fully qualified names for hash interfaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by rsc

Modified:
15 years, 6 months ago

Reviewers:
r, r1

Visibility:
Public.

Description

use fully qualified names for hash interfaces Fixes issue 38.

Patch Set 1 #

Patch Set 2 : code review 152072: use fully qualified names for hash interfaces #

Patch Set 3 : code review 152072: use fully qualified names for hash interfaces #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	src/pkg/crypto/md5/md5.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/sha1/sha1.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/hash/adler32/adler32.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/hash/crc32/crc32.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

15 years, 6 months ago (2009-11-11 20:00:17 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5ee87a245bb5 ***

use fully qualified names for hash interfaces

Fixes issue 38.

R=r1, r
http://codereview.appspot.com/152072

Expand All Messages | Collapse All Messages